Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the classic output span the actual width of the tty so you can see the actual path with a long file name. #92

Merged
merged 3 commits into from
Sep 26, 2017
Merged

Make the classic output span the actual width of the tty so you can see the actual path with a long file name. #92

merged 3 commits into from
Sep 26, 2017

Conversation

redshodan
Copy link
Contributor

Example, before and after:

baron@dib ~/src/eyeD3 $ eyeD3 "/data/tater-salad-music/The Cure/1979.05.09 - Peel Session/Cure, The - 01 - Desperate Journalist In Ongoing Meaningful Review Situation.mp3"
...Desperate Journalist In Ongoing Meaningful Review Situation.mp3 [ 3.07 MB ]
-------------------------------------------------------------------------------
Time: 02:40	MPEG1, Layer III	[ 160 kb/s @ 44100 Hz - Joint stereo ]
-------------------------------------------------------------------------------
ID3 v2.4:
title: Desperate Journalist In Ongoing Meaningful Review Situation
artist: Cure, The
album: Peel Session
album artist: None
recording date: 1979
track: 1/5		genre: Alternative (id 20)
Comment: [Description: ] [Lang: XXX]
May 9, 1979
-------------------------------------------------------------------------------
baron@dib ~/src/eyeD3 $ PYTHONPATH=src python -m eyed3.main "/data/tater-salad-music/The Cure/1979.05.09 - Peel Session/Cure, The - 01 - Desperate Journalist In Ongoing Meaningful Review Situation.mp3"
/data/tater-salad-music/The Cure/1979.05.09 - Peel Session/Cure, The - 01 - Desperate Journalist In Ongoing Meaningful Review Situation.mp3                                                             [ 3.07 MB ]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 02:40	MPEG1, Layer III	[ 160 kb/s @ 44100 Hz - Joint stereo ]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ID3 v2.4:
title: Desperate Journalist In Ongoing Meaningful Review Situation
artist: Cure, The
album: Peel Session
album artist: None
recording date: 1979
track: 1/5		genre: Alternative (id 20)
Comment: [Description: ] [Lang: XXX]
May 9, 1979
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

@coveralls
Copy link

coveralls commented Sep 25, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 67.202% when pulling d4fcf9f on redshodan:master into 6fd295a on nicfit:master.

nicfit
nicfit requested changes Sep 25, 2017
View reviewed changes
src/eyed3/utils/console.py Outdated
try:
data = fcntl.ioctl(fd, termios.TIOCGWINSZ, '\0' * 4)
hw = struct.unpack("hh", data)
except:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list the expceptions to pass on?

@coveralls
Copy link

coveralls commented Sep 25, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 67.202% when pulling 9d8e8ef on redshodan:master into 6fd295a on nicfit:master.

@redshodan
Copy link
Contributor Author

Done.

@nicfit nicfit merged commit 3e99546 into nicfit:master Sep 26, 2017
nicfit added a commit that referenced this pull request Sep 27, 2017
@nicfit
Merge branch 'master' of github.com:nicfit/eyeD3
d7b9113 
* 'master' of github.com:nicfit/eyeD3:
  Make the classic output span the actual width of the tty so you can see the actual path with a long file name. (#92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicfit nicfit nicfit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redshodan @coveralls @nicfit